Skip to content

kvrpcpb: add delete flag to RawCASRequest to enable compare-and-delete#1420

Open
healthwaite wants to merge 1 commit intopingcap:masterfrom
healthwaite:compare-and-delete2
Open

kvrpcpb: add delete flag to RawCASRequest to enable compare-and-delete#1420
healthwaite wants to merge 1 commit intopingcap:masterfrom
healthwaite:compare-and-delete2

Conversation

@healthwaite
Copy link

@healthwaite healthwaite commented Feb 18, 2026

Add a delete flag into the RawCASRequest message. This allows us to extend the CompareAndSwap API to implement compare and delete semantics as discussed in this issue. When delete is set CompareAndSwap will delete the key if cur_val==expected_val.

Accompanying tikv PR here

@ti-chi-bot ti-chi-bot bot added the size/XXL label Feb 18, 2026
@pingcap-cla-assistant
Copy link

pingcap-cla-assistant bot commented Feb 18, 2026

CLA assistant check
All committers have signed the CLA.

@healthwaite
Copy link
Author

Is it possible anyone can take a look at reviewing this please? Possiby @cfzjywxk? The accompanying tikv PR has been reviewed and approved.

Signed-off-by: Alex Reid <areid@akamai.com>
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: glorv
Once this PR has been reviewed and has the lgtm label, please assign cfzjywxk for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Feb 25, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-02-25 02:25:30.567028781 +0000 UTC m=+235403.081823390: ☑️ agreed by glorv.

@healthwaite
Copy link
Author

Any chance you can take a look at this when you have a second please @cfzjywxk ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants