Flash: add MPP sql digest and connection metadata tracing#10735
Flash: add MPP sql digest and connection metadata tracing#10735JaySon-Huang wants to merge 2 commits intomasterfrom
Conversation
|
Environment preparation failed after 3 attempts due to upstream infrastructure overload (503 Service Unavailable). Please retry the review when the service recovers. ℹ️ Learn more details on Pantheon AI. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
📝 WalkthroughWalkthroughThis pull request propagates SQL digest and connection context information through the MPP task execution pipeline by introducing new member variables in DAGContext and MPPTaskStatistics to track sql_digest, connection_id, and connection_alias, alongside corresponding logging enhancements. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
What problem does this PR solve?
Issue Number: ref pingcap/tidb#66762
rely on pingcap/kvproto#1428
Problem Summary:
What is changed and how it works?
TaskMeta.sql_digestintoDAGContextand expose it via getter.MPPTaskStatistics::logTracingJson) to printsql_digest,connection_id, andconnection_alias.FlashService::DispatchMPPTaskhandling log withsql_digest.contrib/kvprotosubmodule pointer to include matched proto changes.Check List
Tests
Side effects
Documentation
Release note
Summary by CodeRabbit
Release Notes
New Features
Chores