proxy: request quickack before frontend reads#1091
Draft
baiyuqing wants to merge 4 commits intoserverlessfrom
Draft
proxy: request quickack before frontend reads#1091baiyuqing wants to merge 4 commits intoserverlessfrom
baiyuqing wants to merge 4 commits intoserverlessfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Problem Summary:
In the serverless gateway path, the frontend socket can occasionally delay pure ACKs long enough for clients to hit the Linux
~200msretransmission window. That shows up as sporadic max-latency spikes even when TiDB itself is stable.What is changed and how it works:
PacketIOoption to requestTCP_QUICKACKReadPacket()so the socket re-enters quickack mode after the kernel leaves itThis keeps the change narrowly scoped to the client -> TiProxy side where delayed ACKs were suspected to amplify tail latency.
Check List
Tests
Test details:
go test ./pkg/proxy/net ./pkg/proxy/client ./pkg/proxyaws-shared-provider:GOSUMDB=off go test ./pkg/gateway/... ./cmd/tidb-gateway/...Notable changes
Release note