Attempt to fix MetadataClient reflections race condition #119
+31
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vahidhashemian
approved these changes
Jan 9, 2026
jeffxiang
added a commit
that referenced
this pull request
Jan 10, 2026
jeffxiang
added a commit
that referenced
this pull request
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Race condition occurs when static initialization in this class competes with
Reflectionsdiscovery of plugin annotations in https://github.com/pinterest/psc/blame/4.0/psc/src/main/java/com/pinterest/psc/consumer/creation/PscConsumerCreatorManager.java#L18 and the producer equivalent. Enclosing the discovery logic in a synchronized block will force the 3 CreatorManager classes to perform reflection discovery serially and avoid clashes.