Skip to content

Tidying up to clear Closure Compiler warnings #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
max-morawski-photo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tidying up to clear Closure Compiler warnings #112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions pinit_main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2522,9 +2522,7 @@
}

if (r.status === "failure") {
if (boardOrSection === "board") {
// Board does not exist - do nothing
}
// boardOrSection === "board" -- do nothing about a missing board
if (boardOrSection === "section") {
// API returned an error when checking for the Section level i.e. Section does not exist, so let's show the Board level if it exists
$.f.seek.embedBoard(a, href, true);
Expand Down Expand Up @@ -3327,8 +3325,7 @@
fontFamily: true,
textAlign: true,
color: true,
fontSize: true,
display: true
fontSize: true
},
setData: {
href: true,
Expand Down Expand Up @@ -4376,7 +4373,6 @@
"border-radius": "%buttonBorderRadius%",
font:
'bold 11px/20px "Helvetica Neue", Helvetica, arial, sans-serif !important',
"box-sizing": "border-box",
cursor: "pointer",
"%prefix%font-smoothing": "antialiased",
height: "20px",
Expand Down Expand Up @@ -4427,7 +4423,6 @@
position: "relative",
font: '12px "Helvetica Neue", Helvetica, arial, sans-serif',
color: "#555",
"box-sizing": "border-box",
"text-align": "center",
"vertical-align": "baseline",
"&:hover": {
Expand Down Expand Up @@ -4500,7 +4495,6 @@
color: "#fff!important",
background: "%saveButtonBackgroundColor% url(%logo%) 3px 50% no-repeat",
"background-size": "14px 14px",
"font-weight": "bold",
"-webkit-font-smoothing": "antialiased",
"._count": {
"text-indent": "0",
Expand Down