mow plant harvest blueprint with dynamic tractor data #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…otocol into mow-plant-harvest-blueprint
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…otocol into mow-plant-harvest-blueprint
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
fr1jo
reviewed
Dec 23, 2025
…oHelpers instead of redefining them locally
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…o-org/protocol into pocikerim/mow-plant-harvest
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
…d operator validation and tip resolution logic
…olvedSourceIsBean and _enforceWithdrawalPlanAndTip
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
fr1jo
requested changes
Jan 3, 2026
Contributor
fr1jo
left a comment
fr1jo
left a comment
There was a problem hiding this comment.
review III. needs 1 more small-medium refactor, but 95% of the way there!
| int96 plantedStem, | ||
| uint256 maxGrownStalkPerBdv, | ||
| uint256 slippageRatio | ||
| ) internal { |
Contributor
There was a problem hiding this comment.
you need to add back the previous logic where we only perform this special logic if the token they want to tip from is the pinto token. Unclear why that was removed. should be able to copy paste this directly from a previous commit.
905d012#diff-00263ed26b5d1f84db9835491aa9430aa4d226b0919134fd66fef150d7ad8c1aL594-L624
also, in. _resolvedSourceIsBean, if (sourceTokenIndices.length == 0) return false; is redundant. _validateSourceTokens already checks that sourceTokenIndices.length > 0.
…nd fix minTwaDeltaB naming
…ot indexes directly
…g minHarvestAmount in struct
…' into pocikerim/mow-plant-harvest
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.