docs: fix typos in task descriptions and NatSpec #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed 'improvment' to 'improvement' in PI-1 through PI-6 task descriptions - Fixed 'concatination' to 'concatenation' in MetadataFacet.sol NatSpec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed 'improvment' to 'improvement' in PI-1 through PI-6 task descriptions
Fixed 'concatination' to 'concatenation' in MetadataFacet.sol NatSpec
Title: PI-X <ADD_DESCRIPTION>
Summary
In a few bullet points, describe the purpose of this PI
Links
Problem
Briefly describe the problem we are trying to solve with this PI
Solution
Present an overview of the code components added-removed along with any formulas utilized/modified
Rationale
Explain the general rationale here if needed
Economic Rationale
Explain the economic implications in the model that this PI introduces
Contract Changes
The format of this section is found below. Repeat this by the facets changed and replace the addresses and facets that changed as needed. If no new functionality is introduced, omit the checkmark
The following Facets were upgraded with new functionality:
FacetName
Removed:
0x42575b2F01D18Cf3Ed670C9fE82ee90332739D03Added:
0x046c76Aee5D109fBa8708ee58a50d76EEa1f98dCFacetNameFunction ChangesselectorName0xselectorBytes