Fix for Person Search using country code and phone number#9
Open
BenYarbro wants to merge 9 commits intopiplcom:masterfrom
Open
Fix for Person Search using country code and phone number#9BenYarbro wants to merge 9 commits intopiplcom:masterfrom
BenYarbro wants to merge 9 commits intopiplcom:masterfrom
Conversation
… and phone (not raw phone) caused false unsearchable flag.
…hen doing a Person search using country code and number.
…ty in browser URL post.
… and also do tests for negative numbers, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Yuri. As we discussed, here is the fix using a c# Person search using country code and phone number where code did not allow a number of combinations allowed by browser interface. I've simplified it since we spoke last and wrote more tests to prove the code. The code now simulates the browser function. See changes in Phone.cs IsSearchable.
I also added all the tests for future users edification.
-Ben