Added "bypassCache" option to let the browser cache the images.#15
Open
eguaj wants to merge 1 commit intopixedelic:masterfrom
Open
Added "bypassCache" option to let the browser cache the images.#15eguaj wants to merge 1 commit intopixedelic:masterfrom
eguaj wants to merge 1 commit intopixedelic:masterfrom
Conversation
|
I'm glad this has been proposed. Cache busting should be disabled by default, however. I'm not sure of the use case for loading every image every page load, but allowing images to cache by default would improve user experience. Cache busting should be enabled only when needed. |
|
Is this likely to be merged? Would be good to have the possibility to disable this feature. |
By default, image's URLs are suffixed with a timestamp which prevent the browser from caching the image. Setting "bypassCache: false" disable this suffix, and allow the browser to cache the images and do If-Modified-Since requests instead of fetching the whole image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, image's URLs are prefixed with a timestamp which prevent
the browser from caching the image.
Setting "bypassCache: false" disable this prefix, and allow the browser
to cache the images and do If-Modified-Since requests instead of
fetching the whole image.