Address compression related memory handling.#164
Open
levigroker wants to merge 1 commit intopixelglow:masterfrom
Open
Address compression related memory handling.#164levigroker wants to merge 1 commit intopixelglow:masterfrom
levigroker wants to merge 1 commit intopixelglow:masterfrom
Conversation
Specifically: `open` now checks the stream status before potentially opening again (and leaking memory). `close` now checks stream status before attempting to close (potentially closing an already closed stream). Also an autoreleasepool now wraps the NSData object creation. Since `close` may be called in tight loops, this correctly releases memory in a timely manner. `write:maxLength:` now is wrapped in an autoreleasepool. Since this is called in tight loops, the creation of the `outputBuffer` was causing memory to grow as a compresion was underway. The autoreleasepool mitigates this situation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically:
opennow checks the stream status before potentially opening again (and leaking memory).closenow checks stream status before attempting to close (potentially closing an already closed stream). Also an autoreleasepool now wraps the NSData object creation. Sinceclosemay be called in tight loops, this correctly releases memory in a timely manner.write:maxLength:now is wrapped in an autoreleasepool. Since this is called in tight loops, the creation of theoutputBufferwas causing memory to grow as a compresion was underway. The autoreleasepool mitigates this situation.