Skip to content

OSS-Fuzz: Fix fuzz-sip-transaction to avoid network sending#4849

Merged
sauwming merged 3 commits intopjsip:masterfrom
arthurscchan:fix-sip-transaction
Mar 13, 2026
Merged

OSS-Fuzz: Fix fuzz-sip-transaction to avoid network sending#4849
sauwming merged 3 commits intopjsip:masterfrom
arthurscchan:fix-sip-transaction

Conversation

@arthurscchan
Copy link
Contributor

This PR fixes fuzz-sip-transaction to prevent the fuzzer from attempting network operations that cause assertion failures, as OSS-Fuzz does not support network connectivity.

Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
@arthurscchan arthurscchan marked this pull request as ready for review March 11, 2026 23:32
@sauwming sauwming requested a review from Copilot March 11, 2026 23:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the fuzz-sip-transaction OSS-Fuzz target to avoid triggering actual SIP transaction sends, which can attempt network operations and cause assertions in environments without network connectivity.

Changes:

  • Stop sending messages via pjsip_tsx_send_msg() in both UAS and UAC fuzz paths.
  • Keep exercising message/transaction creation while ensuring objects are cleaned up via termination and refcount release.

You can also share your feedback on Copilot code review. Take the survey.

Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
nanangizz added a commit that referenced this pull request Mar 12, 2026
Add -std=gnu89 -Werror=declaration-after-statement to the default-build
CI jobs (Linux and macOS) to catch C99-style mixed declarations and code.
Fix all existing violations in the codebase.

Co-Authored-By: Claude Code
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
@sauwming sauwming added this to the release-2.17 milestone Mar 12, 2026
@sauwming sauwming requested a review from nanangizz March 12, 2026 23:22
@nanangizz
Copy link
Member

Just FYI, there is a loopback SIP transport that works without using network connectivity.

@sauwming sauwming merged commit 83aa137 into pjsip:master Mar 13, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants