Fix occasional crash on send manager startup#4856
Open
kunkku wants to merge 1 commit intopjsip:masterfrom
Open
Fix occasional crash on send manager startup#4856kunkku wants to merge 1 commit intopjsip:masterfrom
kunkku wants to merge 1 commit intopjsip:masterfrom
Conversation
This commit ensures the manager's group lock has a positive reference count before the thread starts. Otherwise, an assertion may fail in pj_grp_lock_acquire.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an occasional startup crash in the video stream send manager by ensuring the send manager’s group lock has a positive reference count before its worker thread can attempt pj_grp_lock_acquire().
Changes:
- Move
pj_grp_lock_add_ref()to occur before creating the send manager thread. - Refactor the pool variable scope so thread creation can be gated on whether the manager was initialized in this call.
- Return
PJ_SUCCESSafter successful attach (instead of returning the add-ref result at the end).
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures the video stream send manager's group lock has a positive reference count before the thread starts. Otherwise, an assertion may fail in
pj_grp_lock_acquire, which is about the first thing called by the new thread.