CI: Fetch all commits and tags #309
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for now because of how setuptools_scm relies on tags and the number of commits since that tag to determine the version number string. (Without that info, the version will be named "0.1.dev1+g(hash)" every time, possibly even for actual releases.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for now because of how setuptools_scm relies on tags and the number of commits since that tag (via
git describe, I guess) to determine the version number string. (Without that info, the version will be named "0.1.dev1+g(hash)" every time, possibly even for actual releases.)A more efficient solution may be possible in the future; see actions/checkout#249 and pypa/setuptools-scm#480
I've pushed the official
v4.2tag to my forked repo to make sure that this works before merging it.