Prevent duplicated ChatList events

[MattBillFred]

Prevent ChatList from generating duplicate events.

A duplicate event is being thrown any time one of the callback functions gets recreated. In the previous version of the code, the useEffect would trigger off of any change to any callback and would preprocess the event as if it had just come in. Now, events will only processed if they are generated by the StatefulGraphChatListClient.

Additionally, the StatefulGraphChatListClient was not removing handlers during the offStateChange(). (splice() returns what was removed, so the handler that was being removed from _subscribers was being added back.)

Steps to validate behavior:

Update onMessageReceived in samples\react-chat\src\App.tsx to be:

  const onMessageReceived = useCallback((msg: ChatMessage) => {
    console.log('SampleChatLog: Message received', msg, chatThreadsPerPage);
  }, [chatThreadsPerPage]);

Run the demo app using yarn watch:chat.

Open the Dev Tools and view the console.

From another user, send a message to the sample application.

Switch the "Number of Chat Threads per Page" drowdown.

Old behavior:

• Initial message sent from other user would trigger twice.
• Each time the drop down was changed, the message would trigger again.

New behavior:

• Initial message sent from other user would trigger only once.
• Changing the drop down does not re-trigger the message.

[github-actions]

Package	Line Rate	Branch Rate	Complexity	Health
mgt-chat.src.statefulClient	100%	100%	0	✔
mgt-chat.src.utils	100%	92%	0	✔
mgt-components.dist.es6.components.mgt-agenda.src.components.mgt-agenda	14%	100%	0	❌
mgt-components.dist.es6.components.mgt-contact.src.components.mgt-contact	62%	100%	0	➖
mgt-components.dist.es6.components.mgt-file-list.mgt-file-upload.src.components.mgt-file-list.mgt-file-upload	43%	100%	0	❌
mgt-components.dist.es6.components.mgt-file-list.src.components.mgt-file-list	62%	100%	0	➖
mgt-components.dist.es6.components.mgt-file.src.components.mgt-file	61%	100%	0	➖
mgt-components.dist.es6.components.mgt-get.src.components.mgt-get	19%	100%	0	❌
mgt-components.dist.es6.components.mgt-login.src.components.mgt-login	64%	100%	0	➖
mgt-components.dist.es6.components.mgt-messages.src.components.mgt-messages	66%	100%	0	➖
mgt-components.dist.es6.components.mgt-organization.src.components.mgt-organization	46%	100%	0	❌
mgt-components.dist.es6.components.mgt-people-picker.src.components.mgt-people-picker	56%	100%	0	➖
mgt-components.dist.es6.components.mgt-people.src.components.mgt-people	72%	100%	0	➖
mgt-components.dist.es6.components.mgt-person-card.src.components.mgt-person-card	59%	33%	0	➖
mgt-components.dist.es6.components.mgt-person.src.components.mgt-person	53%	100%	0	➖
mgt-components.dist.es6.components.mgt-picker.src.components.mgt-picker	78%	100%	0	✔
mgt-components.dist.es6.components.mgt-planner.src.components.mgt-planner	55%	100%	0	➖
mgt-components.dist.es6.components.mgt-profile.src.components.mgt-profile	39%	100%	0	❌
mgt-components.dist.es6.components.mgt-search-box.src.components.mgt-search-box	83%	100%	0	✔
mgt-components.dist.es6.components.mgt-search-results.src.components.mgt-search-results	56%	100%	0	➖
mgt-components.dist.es6.components.mgt-tasks-base.src.components.mgt-tasks-base	86%	100%	0	✔
mgt-components.dist.es6.components.mgt-taxonomy-picker.src.components.mgt-taxonomy-picker	74%	100%	0	➖
mgt-components.dist.es6.components.mgt-teams-channel-picker.src.components.mgt-teams-channel-picker	62%	100%	0	➖
mgt-components.dist.es6.components.mgt-theme-toggle.src.components.mgt-theme-toggle	74%	100%	0	➖
mgt-components.dist.es6.components.mgt-todo.src.components.mgt-todo	78%	100%	0	✔
mgt-components.dist.es6.components.src.components	86%	100%	0	✔
mgt-components.dist.es6.components.sub-components.mgt-arrow-options.src.components.sub-components.mgt-arrow-options	76%	100%	0	✔
mgt-components.dist.es6.components.sub-components.mgt-dot-options.src.components.sub-components.mgt-dot-options	29%	100%	0	❌
mgt-components.dist.es6.components.sub-components.mgt-flyout.src.components.sub-components.mgt-flyout	40%	100%	0	❌
mgt-components.dist.es6.components.sub-components.mgt-spinner.src.components.sub-components.mgt-spinner	92%	100%	0	✔
mgt-components.dist.es6.graph.src.graph	36%	100%	0	❌
mgt-components.dist.es6.src	100%	100%	0	✔
mgt-components.dist.es6.styles.src.styles	73%	100%	0	➖
mgt-components.dist.es6.utils.src.utils	46%	100%	0	❌
mgt-components.src.components	84%	75%	0	✔
mgt-components.src.components.mgt-contact	68%	83%	0	➖
mgt-components.src.components.mgt-file	62%	100%	0	➖
mgt-components.src.components.mgt-file-list	46%	100%	0	❌
mgt-components.src.components.mgt-file-list.mgt-file-upload	49%	86%	0	❌
mgt-components.src.components.mgt-get	22%	100%	0	❌
mgt-components.src.components.mgt-messages	68%	100%	0	➖
mgt-components.src.components.mgt-organization	47%	100%	0	❌
mgt-components.src.components.mgt-person	84%	76%	0	✔
mgt-components.src.components.mgt-person-card	67%	48%	0	➖
mgt-components.src.components.mgt-picker	80%	100%	0	✔
mgt-components.src.components.mgt-profile	40%	100%	0	❌
mgt-components.src.components.mgt-tasks-base	87%	100%	0	✔
mgt-components.src.components.mgt-theme-toggle	100%	100%	0	✔
mgt-components.src.components.mgt-todo	79%	100%	0	✔
mgt-components.src.components.sub-components.mgt-flyout	72%	53%	0	➖
mgt-components.src.components.sub-components.mgt-spinner	100%	100%	0	✔
mgt-components.src.graph	40%	73%	0	❌
mgt-components.src.styles	92%	80%	0	✔
mgt-components.src.utils	82%	46%	0	✔
mgt-element.dist.es6.components.src.components	72%	74%	0	➖
mgt-element.dist.es6.mock.src.mock	91%	77%	0	✔
mgt-element.dist.es6.providers.src.providers	87%	83%	0	✔
mgt-element.dist.es6.src	91%	80%	0	✔
mgt-element.dist.es6.utils.src.utils	67%	73%	0	➖
mgt-element.src	93%	40%	0	✔
mgt-element.src.components	78%	100%	0	✔
mgt-element.src.mock	81%	56%	0	✔
mgt-element.src.providers	84%	91%	0	✔
mgt-element.src.utils	71%	90%	0	➖
Summary	60% (28097 / 46619)	71% (564 / 796)	0	➖