Adapt for external PHP builds #293
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the static-php-cli submodule from commit 4c55f4a2 to v2.7.5 (c5ae719b). Changes made to adapt to v2.7.5: - Replace legacy Docker build script approach with spc-alpine-docker tool. - Add ext/craft.yml to configure PHP extensions (curl, filter, openssl, pcntl, phar, posix, zlib). - Update Makefile to use new build command via spc-alpine-docker. The new version uses a unified craft.yml configuration format and bin/spc tool instead of the legacy docker/ directory with manual build scripts. Co-Authored-By: Claude <noreply@anthropic.com>
Use static-php-cli's craft command instead of separate download and build commands. This eliminates the duplication of the extensions list and aligns with the configuration-driven approach in craft.yml. Also remove invalid with-strip-php option from craft.yml (stripping is the default behavior). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Document craft-options based on static-php-cli documentation: doctor checks the environment, download fetches php-src and libraries, and build compiles the static binary. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
PHP binaries are now downloaded from upsun/cli-php-builds releases instead of being built locally. This decouples PHP builds from CLI releases and simplifies the build process. Changes: - Makefile: Replace local build targets with download targets - php_manager_windows.go: Simplify to use static binary (no ZIP/DLLs) - CLAUDE.md: Update build documentation - Remove ext/ submodule and build-php-brew.sh 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
pjcdawkins
force-pushed
the
externalize-php-build
branch
from
a72b488 to
bd4d659
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
ext/submodule (~180MB) andbuild-php-brew.shTest plan
make phpdownloads PHP binary from cli-php-buildsmake singlebuilds CLI successfullyupsun version,upsun list)🤖 Generated with Claude Code