-
Notifications
You must be signed in to change notification settings - Fork 349
Rolling and Manual deployments corrections #5265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Rolling and Manual deployments corrections #5265
Conversation
davidbonachera
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added 2 ideas.
|
|
||
| {{< note theme="info" >}} | ||
|
|
||
| If the last deployment failed, you can only use the default stop-start strategy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to elaborate on why ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it would be helpful to elaborate
catplat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested several edits and made comments
|
|
||
| {{< note theme="info" >}} | ||
|
|
||
| If the last deployment failed, you can only use the default stop-start strategy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it would be helpful to elaborate
| - When deployment is complete, the clone of your app is shut down and removed. | ||
| - All traffic and services are now solely applied to the original app alone. | ||
| - The original app is updated with the new code and configuration. | ||
| - The deploy hook is run on the original app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the deploy hook the only thing that is run? Are pre-start commands also run? (Wondering if we need to map this more closely to the steps in the "Deploy steps" section)
| **You are billed for extra resources while both app versions active.** If your app’s deployment phase takes longer and uses more resources, expect proportionally higher costs. | ||
| {{< /note >}} | ||
|
|
||
| ### Deployment strategies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we made this a H2 instead of H3, so it's at the same level as "deployment type" and not buried in ZDD content? Additionally, what if we made ZDD headings subheadings of Rolling deployment - assuming the goal is treating ZDD as just the implementation of the rolling deployment strategy?
What's changed
All the points are IMHO, please feel free to reject.
Manual Deployments
ZDD
Where are changes
Updates are for:
sites/platformtemplates)sites/upsuntemplates)