Skip to content

Conversation

@vitolkachova
Copy link

What's changed

All the points are IMHO, please feel free to reject.

Manual Deployments

  • available on all env types, no need to mention that, the obsolete section removed
  • removed --help section of CLI command, I think it's obvious enough
  • mention that redeploy does not apply staged changes

ZDD

  • rework "How to use ZDD" the CLI part, add the code push
  • fixed the MDN refernce for retry logic
  • add missing section in zdd flow with the original app update
  • add info section, that after a failed deployment only stopstart can be used
  • wording here and there (misused deploy hook)

Where are changes

Updates are for:

  • platform (sites/platform templates)
  • upsun (sites/upsun templates)

@flovntp flovntp added the build-fork To build PRs from forks label Dec 15, 2025
Copy link
Contributor

@davidbonachera davidbonachera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 2 ideas.


{{< note theme="info" >}}

If the last deployment failed, you can only use the default stop-start strategy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to elaborate on why ?

Copy link
Collaborator

@catplat catplat Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it would be helpful to elaborate

Copy link
Collaborator

@catplat catplat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested several edits and made comments


{{< note theme="info" >}}

If the last deployment failed, you can only use the default stop-start strategy.
Copy link
Collaborator

@catplat catplat Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it would be helpful to elaborate

- When deployment is complete, the clone of your app is shut down and removed.
- All traffic and services are now solely applied to the original app alone.
- The original app is updated with the new code and configuration.
- The deploy hook is run on the original app.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the deploy hook the only thing that is run? Are pre-start commands also run? (Wondering if we need to map this more closely to the steps in the "Deploy steps" section)

**You are billed for extra resources while both app versions active.** If your app’s deployment phase takes longer and uses more resources, expect proportionally higher costs.
{{< /note >}}

### Deployment strategies
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we made this a H2 instead of H3, so it's at the same level as "deployment type" and not buried in ZDD content? Additionally, what if we made ZDD headings subheadings of Rolling deployment - assuming the goal is treating ZDD as just the implementation of the rolling deployment strategy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-fork To build PRs from forks markdown/prose

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants