Use LimitExpr instead of QueryExpr for limit#4
Open
hiro1107 wants to merge 4 commits intoplausible:masterfrom
Open
Use LimitExpr instead of QueryExpr for limit#4hiro1107 wants to merge 4 commits intoplausible:masterfrom
hiro1107 wants to merge 4 commits intoplausible:masterfrom
Conversation
update limit
Bump version to 0.2.9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six months ago, Ecto added LimitExpr module and now clickhouse_ecto's limit function returns match error.
(FunctionClauseError) no function clause matching in ClickhouseEcto.QueryString.limit/2
I replaced QueryExpr with LimitExpr to avoid the error.
https://github.com/elixir-ecto/ecto/blob/master/lib/ecto/query.ex