Sync collection #74
Open
Sync collection #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crutchcorn
commented
Dec 10, 2025
| .values(result) | ||
| .onConflictDoUpdate({ target: [collectionData.slug, collectionData.locale], set: result }); | ||
|
|
||
| // TODO: How to handle authors? |
Member
Author
There was a problem hiding this comment.
From @fennifith:
You can assume the author profile should already exist in the db (if they don't, the task should fail) - so it's just a matter of adding to the
collection_authorstable.
fennifith
reviewed
Jan 3, 2026
| slug: text("slug").primaryKey(), | ||
| }); | ||
|
|
||
| // TODO: This is missing a ton of fields that are in the Collections task type, what do? |
Member
There was a problem hiding this comment.
Not sure what type you're referencing here? What fields are missing?
The collection_data table does not need to contain every value that's in the frontmatter IMO - it should all be available in the meta column regardless.
| ], | ||
| ); | ||
|
|
||
| // TODO: Do we need this in the DB or can it just be in the meta JSON? |
Member
There was a problem hiding this comment.
Yes, to support queries like "list posts by collection". These can't be added until the post is created, though - sync-post will need to additionally fetch the collection data to create this record.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32
Needs a review to address code
// TODOs, since it will impact how we handle the code from here outOther TODOs