Add missing 'PlayDialog-turbo' to VoiceEngine options#65
Open
FAHADPN wants to merge 1 commit intoplayht:mainfrom
Open
Add missing 'PlayDialog-turbo' to VoiceEngine options#65FAHADPN wants to merge 1 commit intoplayht:mainfrom
'PlayDialog-turbo' to VoiceEngine options#65FAHADPN wants to merge 1 commit intoplayht:mainfrom
Conversation
Author
|
solves issue #64 |
Contributor
|
Hey, thanks for this PR. This is a good change, although I'm curious what was your use case, where this I ask because, per this test, the |
Author
|
Thanks! The main reason for this change was to make the mapping between my custom model and voice engine explicit and type-safe. While |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The
'PlayDialog-turbo'voice engine was missing from theVoiceEnginetype definition, even though the model is supported by the package. This update adds the missing option to ensure accurate type coverage and prevent potential runtime mismatches.Changes Made: