Correctly escape newlines in tr invocations
#48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replacement of newlines with colons doesn't work as expected - it replaces literal `n` characters, not newlines: ``` $ echo -e "one\ntwo\nthree" | tr \\\\n : o:e two three ``` Simplify the `tr` invocation and ensure it actually replaces newlines.
peterebden
approved these changes
Nov 22, 2024
chrisnovakovic
requested review from
toastwaffle
and removed request for
toastwaffle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replacement of newlines with colons doesn't work as expected - it replaces literal
ncharacters, not newlines:Simplify the
trinvocation and ensure it actually replaces newlines.