java_runtime_image: exclude java_toolchain directory from JAR search
#49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a `java_toolchain` is used to build a `java_runtime_image`, the toolchain's files are included in the Please sandbox when remote execution is enabled, and should not be included in the `--module-path` option to jlink. Exclude any JAR files that are part of the toolchain from the jlink module path. Fixes please-build#47.
toastwaffle
approved these changes
Nov 22, 2024
peterebden
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
java_toolchainis used to build ajava_runtime_image, the toolchain's files are included in the Please sandbox when remote execution is enabled, and should not be included in the--module-pathoption to jlink. Exclude any JAR files that are part of the toolchain from the jlink module path.Fixes #47.