Skip to content

Conversation

@SkeneZr
Copy link
Contributor

@SkeneZr SkeneZr commented Apr 18, 2025

in verbosity debug, I see that {test_package} is not substituted

$TOOLS_JAVA -Dbuild.please.testpackage={test_package} -jar ./unit__common.jar

@toastwaffle
Copy link

@SkeneZr this looks fine to me. Could you do a patch version bump in the VERSION file and update ChangeLog so that this gets released immediately?

Copy link
Contributor

@Tatskaari Tatskaari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@SkeneZr
Copy link
Contributor Author

SkeneZr commented May 20, 2025

@SkeneZr this looks fine to me. Could you do a patch version bump in the VERSION file and update ChangeLog so that this gets released immediately?

Done

@toastwaffle toastwaffle merged commit 878a3e6 into please-build:master May 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants