Define in-repo Python interpreters for all supported platforms #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including, for the first time, FreeBSD. This involves a bit of a kludge: python-build-standalone doesn't produce FreeBSD-compatible releases, so we have to manually download and unpack the Ports packages and patch the binaries so they behave like standalone interpreters. This will allow us to run the tests on all platforms as part of CI testing and produce FreeBSD-compatible versions of please_pex when the time comes.
toastwaffle
approved these changes
Nov 21, 2025
| subinclude("//build_defs:archs") | ||
|
|
||
| _python_build_standalone_release = "20251031" | ||
| _python_build_standalone_hashes = { |
Contributor
There was a problem hiding this comment.
Do you have a mechanism for updating all of these hashes?
Contributor
Author
There was a problem hiding this comment.
Nothing beyond Ctrl+C and Ctrl+V, I'm afraid. I don't anticipate having to change them often (except perhaps in the short term for the FreeBSD ones, which for now are being taken from the Latest Ports branch because there hasn't yet been a Quarterly release containing Python 3.13 and 3.14).
chrisnovakovic
added a commit
to chrisnovakovic/python-rules
that referenced
this pull request
Dec 1, 2025
The in-repo interpreters were moved from `third_party/cpython/lib` to `third_party/cc/cpython` in please-build#277, but the interpreter directory path in `//test:interpreter_not_included_test` wasn't also updated, so the test still passes even if please_pex erroneously packs the in-repo interpreter into the .pex file. Update the path to fix the test.
chrisnovakovic
added a commit
that referenced
this pull request
Dec 1, 2025
The in-repo interpreters were moved from `third_party/cpython/lib` to `third_party/cc/cpython` in #277, but the interpreter directory path in `//test:interpreter_not_included_test` wasn't also updated, so the test still passes even if please_pex erroneously packs the in-repo interpreter into the .pex file. Update the path to fix the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including, for the first time, FreeBSD. This involves a bit of a kludge: python-build-standalone doesn't produce FreeBSD-compatible releases, so we have to manually download and unpack the Ports packages and patch the binaries so they behave like standalone interpreters.
This will allow us to run the tests on all platforms as part of CI testing and produce FreeBSD-compatible versions of please_pex when the time comes.