Skip to content

sh_binary: require dependencies' run-time dependencies #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisnovakovic merged 1 commit into from
Dec 9, 2025
Merged

sh_binary: require dependencies' run-time dependencies #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .plzconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Please]
Version = >=17.0.0
Version = >=17.26.0

[PluginDefinition]
Name = shell
Expand Down
3 changes: 2 additions & 1 deletion build_defs/shell.build_defs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def sh_binary(name:str, main:str|list&srcs, out:str="", deps:list=None, data:lis
The resulting script will contain three things:
1) Code necessary to unzip dependent files.
2) The user defined shell script.
3) The zipfile containing all dependent files.
3) The zipfile containing all dependent files, (but not those dependencies' run-time data).

Args:
name (str): Name of the rule
Expand Down Expand Up @@ -86,6 +86,7 @@ def sh_binary(name:str, main:str|list&srcs, out:str="", deps:list=None, data:lis
deps = deps,
binary = True,
needs_transitive_deps = True,
runtime_deps_from_deps = True,
labels = labels,
visibility = visibility,
)
Expand Down