Skip to content

fix iop autoscaling disable by default #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicole-lihui merged 1 commit into from
Dec 29, 2025
Merged

fix iop autoscaling disable by default #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions internal/istio/iop.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,20 +290,22 @@ func (r *IstioOperatorReconciler) convertIopToHelmApp(ctx context.Context, in *i

// spec.values.gateways.istio-ingressgateway.autoscaleEnabled
// spec.values.gateways.istio-egressgateway.autoscaleEnabled
// Default autoscaling is disabled to ensure it can be explicitly disabled
autoscaling := map[string]interface{}{
"enabled": false,
}
autoscaleEnabledKey := fmt.Sprintf("spec.values.%s.autoscaleEnabled", cInfo.Component.ToHelmValuesTreeRoot)
minReplicasKey := fmt.Sprintf("spec.values.%s.autoscaleMin", cInfo.Component.ToHelmValuesTreeRoot)
// Configure autoscaling settings
if enabled := cInfo.Values.GetPathBool(autoscaleEnabledKey); enabled {
autoscaling := map[string]interface{}{
"enabled": enabled,
}
autoscaling["enabled"] = true

if minReplicas := cInfo.Values.GetPathString(minReplicasKey); minReplicas != "" {
autoscaling["minReplicas"] = minReplicas
}

componentValues["autoscaling"] = autoscaling
}
// If autoscaleEnabled is explicitly set to false or not set, autoscaling remains disabled (default)
componentValues["autoscaling"] = autoscaling

// compatible iop gateway template
appValue := "istio-ingressgateway"
Expand Down
Loading
Loading