Fixed handling of an exception within a class constructor#99
Fixed handling of an exception within a class constructor#99atvise wants to merge 1 commit intopmed:masterfrom
Conversation
fcf0a29 to
bcfeb2b
Compare
bcfeb2b to
e68d34f
Compare
|
Hi @atvise, Thanks a lot for the your recent contributions! Excuse me, I really have no spare time to review and merge you pull-request at this time. The Travis CI build could fail due to old V8 versions. So the pre-requisit will be release v8pp version 1.6 with minimum required V8 version 6.3. After that I think your pull-requests would be merged successfully. |
|
Hi @pmed, you'r welcome! No problem ;) If you have time again let me know! |
Idea suggested by pull-request #99
|
Hi, There is already exception handling in JS constructor function: https://github.com/pmed/v8pp/blob/master/v8pp/class.hpp#L69-L76 that translates I've added a couple of checks into the |
b482a7c to
8ab2770
Compare
14bc459 to
352c061
Compare
bd106c3 to
6611145
Compare
4119f8e to
211ef9b
Compare
Added try catch within the class wrap_object function to catch possible exceptions from the ctor_ function