Skip to content

PNDA-4055: Feature flags in YAML config not easily extensible#145

Open
piyushpote1 wants to merge 1 commit intopndaproject:developfrom
piyushpote1:PNDA-4055
Open

PNDA-4055: Feature flags in YAML config not easily extensible#145
piyushpote1 wants to merge 1 commit intopndaproject:developfrom
piyushpote1:PNDA-4055

Conversation

@piyushpote1
Copy link

Problem Statement:

Dependency PR: pndaproject/platform-salt#579
PNDA-4055: Feature flags in YAML config not easily extensible

Changes:

  • Updated pnda_env_example.yaml. Configured features as list of features instead of key-value pairs.
  • Renamed EXPERIMENTAL to a specific optional feature name i.e SPARKMAGIC
  • Updated backend_base.py to handle the list in the yaml file.

Test details

RHEL(CDH pico and HDP pico)

Copy link
Member

@trsmith2 trsmith2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good improvement but the specific features of livy/sparkmagic are no longer supported. Be great to get the general improvement into the code if you can remove the specifics that have since been deprecated.

@trsmith2 trsmith2 added 5.2 and removed 5.2 labels Aug 28, 2018
@trsmith2 trsmith2 added this to the 5.2 milestone Aug 28, 2018
@trsmith2 trsmith2 added the 5.2 label Aug 28, 2018
@trsmith2 trsmith2 removed this from the 5.2 milestone Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants