Open
Conversation
… to a new errors module
…rrors instead of raising just the first one
…or into ValidationError
…eport multiple errors
…to_string() a bit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #11 by making possible to catch all validation errors of a given input instead of just the first one encountered. Any feedback from
valideerusers that would find this enhancement useful would be most welcome before merging it.Summary:
Validator.full_validate()method is introduced, similar tovalidate(). The difference is that invalid inputs raise aMultipleValidationErrorexception, a newValidationErrorsubclass with anerrorsattribute that captures all individual errors in a (flat) list.ContainerValidatorabstract helper class is introduced to act as a base class of container-like validators that need to report multiple errors, without duplicating the logic betweenvalidateandfull_validateor making the former less efficient than necessary by delegating to the latter.HomogeneousSequence,HeterogeneousSequence,MappingandObjectnow extendContainerValidatorand support reporting mutiple errors out of the box.compat.pymodule for Python 2/3 compatibility is replaced by six.errors.pymodule.