Remove System.exit to avoid strange behavour.#20
Open
nigelsim wants to merge 1 commit intopoidasmith:masterfrom
Open
Remove System.exit to avoid strange behavour.#20nigelsim wants to merge 1 commit intopoidasmith:masterfrom
nigelsim wants to merge 1 commit intopoidasmith:masterfrom
Conversation
Owner
|
Unfortunately some other users rely on this behaviour as they are using third party libraries that don't shut down non-daemon threads. I can certainly make it configurable via an INI option. |
Author
|
Fair enough. It may just be easier to provide it as a separate class given the difference is non-trivial. Just a thought. Thanks for the project too, much appreciated. |
|
Thank you for posting this. I had to use this code with 1 minor tweak to get my "Error 109: Pipe Ended" error from Windows. I added a System.exit(0) right before the return 0 to make my Spring application stop gracefully. Woks like a charm now and my service stops and starts gracefully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a service ends using System.exit(), such as in the MainService class, the services control reports Error 1053: The service did not respond to the start or control request in a timely fashion. If I replace this with just returning from main then everything works file.
This is an issue for me because I'd like to just use my normal main entry point, as I utilise Runtime shutdown handlers to cleanup (which also run correctly, despite the service handler freaking out).
Perhaps the answer is actually to change the way MainService runs so that it doesn't call System.exit(). This pull request runs the service in a thread, and uses the main thread to monitor.