Bugfix: call node print function instead of built-in print function #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When printing the AST to a string using the SprintSyntaxTree function, I was seeing pointer addresses being printed to stdout. Upon looking at the code, I found that in the `printFunc` function that writes the AST to a `io.Writer`, the recursive call is incorrectly calling the built-in `print` function instead of `printFunc`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When printing an AST using any of the print functions, (e.g.
PrintSyntaxTreeorSprintSyntaxTree), I found that it is only including the root of the AST. It was also strangely printing a pointer address.Example:
Upon looking at the code, I found that in the
printFuncfunction that writes the AST to aio.Writer, the recursive call is incorrectly calling the built-inprintfunction instead ofprintFunc, so no recursive calls are actually taking place.But after the fix in this PR: