BEEFY Consensus Client #553
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seunlanlege
reviewed
Oct 9, 2025
| #![cfg_attr(not(feature = "std"), no_std)] | ||
| #![allow(clippy::all)] | ||
| #![deny(missing_docs)] | ||
| //#![deny(missing_docs)] |
Member
There was a problem hiding this comment.
Suggested change
| //#![deny(missing_docs)] | |
| #![deny(missing_docs)] |
seunlanlege
reviewed
Oct 9, 2025
| let latest_height = relay_proof.signed_commitment.commitment.block_number; | ||
|
|
||
| if trusted_state.latest_beefy_height >= latest_height { | ||
| Err(anyhow!("Stale height"))? |
Member
There was a problem hiding this comment.
Lets use a typed enum for errors, we can use thiserror::Error
seunlanlege
reviewed
Oct 9, 2025
| let mut authority_indices = Vec::new(); | ||
|
|
||
| for sig in &relay_proof.signed_commitment.signatures { | ||
| let signature = ecdsa::Signature::from_slice(&sig.signature) |
Member
There was a problem hiding this comment.
make this generic since this library will run on near
seunlanlege
reviewed
Oct 9, 2025
Comment on lines
115
to
116
| let proof_hashes: Vec<[u8; 32]> = | ||
| parachain_proof.proof.iter().flatten().map(|node| node.1.into()).collect(); |
Member
There was a problem hiding this comment.
Doesn't seem like we use the u32 index in the proof
Member
|
Looks like a great start, lets get tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the ismp-beefy pallet, a consensus client for ISMP designed to verify Polkadot's BEEFY finality proofs. This implementation allows ISMP to process consensus updates from BEEFY, making it possible to trustlessly verify state commitments.