Skip to content

fix infinite loop in get_rotation_block with O(1) implementation #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
borngraced wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix infinite loop in get_rotation_block with O(1) implementation #621

borngraced wants to merge 1 commit into from

Conversation

@borngraced
Copy link

@borngraced borngraced commented Dec 31, 2025

@Wizdave97
Copy link
Member

Wizdave97 commented Jan 5, 2026

Thanks, I'll take a look.

Wizdave97
Wizdave97 reviewed Jan 5, 2026
View reviewed changes
Copy link
Member

@Wizdave97 Wizdave97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would require some unit tests with historical data, using the current epoch length of BSC

@borngraced
Copy link
Author

borngraced commented Jan 5, 2026

This would require some unit tests with historical data, using the current epoch length of BSC

you mean even the initial code wasn't tested already?

@Wizdave97
Copy link
Member

Wizdave97 commented Jan 5, 2026

We have integration tests, but a unit test is preferred for this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wizdave97 Wizdave97 Wizdave97 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@borngraced @Wizdave97