fix(cursor): make whatnext() consistent with next() at EOF#1540
Open
Aggarwalmansi wants to merge 182 commits intopostmanlabs:developfrom
Open
fix(cursor): make whatnext() consistent with next() at EOF#1540Aggarwalmansi wants to merge 182 commits intopostmanlabs:developfrom
Aggarwalmansi wants to merge 182 commits intopostmanlabs:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
whatnext()was returning a cursor state that does not occur in actual execution when reaching the final iteration.This caused a mismatch between predictive (
whatnext) and actual (next) behavior, leading to incorrect EOF signaling—especially for partitioned runs.What was failing
A unit test in
runner-cursor.test.jsexposed that at the final position:whatnext()predicted EOFnext()did not yet signal EOFThis divergence caused incorrect cursor state prediction.
What changed
whatnext()next()or cursor mutation logicTests