(#63) Add support for remote flag & PouchDB 6.2.#64
Open
filionf wants to merge 2 commits intopouchdb-community:masterfrom
Open
(#63) Add support for remote flag & PouchDB 6.2.#64filionf wants to merge 2 commits intopouchdb-community:masterfrom
filionf wants to merge 2 commits intopouchdb-community:masterfrom
Conversation
Member
|
I added #74, which does the same thing. The difference is I didn't touch the tests, and also committed the new builds from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the support for PouchDB 6.2 by adding the _remote property. It fixes #63.
However, the test do not run successfully (and did not before my modifications) because a new PouchDB with the same name is created in the dump function. When closed, this cause the destruct listeners to be removed, and since the destruct listeners are "global" and by name, they are removed for both databases: the source and the copy for streaming.
I've had the test run successfully by prefixing the copy with "WS$", but I find this hacky so this is not part of this commit. Please advise on this one.