Pouchdb 6.3.4 compatibility#46
Open
jakobwesthoff wants to merge 5 commits intopouchdb-community:masterfrom
Open
Pouchdb 6.3.4 compatibility#46jakobwesthoff wants to merge 5 commits intopouchdb-community:masterfrom
jakobwesthoff wants to merge 5 commits intopouchdb-community:masterfrom
Conversation
Until the corresponding PR is merged into the project, this branch should do the trick. It is a version 1.3.6 + the race condition fix. Once the PR is merged and a new release is issued this needs to be switched back to the real realease.
Collaborator
Author
|
Fixed. The new version of |
gr2m
requested changes
Jul 24, 2017
Collaborator
gr2m
left a comment
gr2m
left a comment
There was a problem hiding this comment.
Thanks! Let's get pouchdb/pouchdb-wrappers#3 merged and released first, so we don’t need to install from github, okay?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to archive compatibility with the current PouchDB release (6.3.4), the following changes were applied:
putimplementation now, which does not usebulkDocsany more, therefore a transformation needs to be applied in this case.pouchdb-wrappersimplementation hasn't been handling theTaskQueuecorrectly. Therefore a race condition could case the transformation methods to be applied twice (Wait for TaskQueue to be ready before calling wrapper chain pouchdb/pouchdb-wrappers#3). Until the corresponding PR is merged and a new release is issued. I linked the dependency directly to the PR branch. I will try and update the PR once a newpouchdb-wrappersrelease is issued.