-
Notifications
You must be signed in to change notification settings - Fork 15
Add array-API support #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
powerfulbean
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @OleBialas for this huge updating and work!
|
My pleasure! Maybe we could do some benchmarks to measure training with and without GPU and add a section to the docs. |
Thanks Ole, glad to hear this! It sounds good to me that we do some benchmarks. I was pretty busy during the past month, but I will start adding new functions following the array-API standard this week. |
I have added support for array-api as described in gh-38
Now, we can use any kind of array supported by the standard.
For example, one could use CUpy and compute TRFs with GPU acceleration.
Thanks to the magic of
array-api-compatthis does not require any breaking API changes.I did make some changes to private functions though and adapted the tests accordingly.
I also changed a few outdated docstrings and started adding type hints.