Add unit tests for EventManager#5
Conversation
This commit adds a new unit test suite for the EventManager class in src/sim/eventq.test.cc. The tests cover the following functionality: - Scheduling events and verifying execution time. - Rescheduling events to a new time. - Descheduling events. - Verifying that scheduling in the past triggers an assertion (death test). - Verifying that events with the AutoDelete flag are automatically deleted after processing. The test file is registered in src/sim/SConscript.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
powerjg
left a comment
powerjg
left a comment
There was a problem hiding this comment.
It would be good to add comments on what each test is actually testing. This also improves the documentation for how the code is supposed to work and make reviewing the tests easier.
Make sure to add the copyright block to the top. You can use copyright Google Inc.
powerjg
left a comment
powerjg
left a comment
There was a problem hiding this comment.
It would be good to add comments on what each test is actually testing. This also improves the documentation for how the code is supposed to work and make reviewing the tests easier.
Make sure to add the copyright block to the top. You can use copyright Google Inc.
1 participant
Added unit tests for EventManager covering schedule, reschedule, deschedule, schedule in past, and auto-delete functionality.
PR created automatically by Jules for task 11510169470615898906 started by @powerjg