Add SyncConfig superclass for sync configurations#492
Merged
Conversation
🦋 Changeset detectedLatest commit: ef22766 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
BaseSyncConfig interface for sync configurationsSyncConfig superclass for sync configurations
stevensJourney
approved these changes
Feb 9, 2026
Collaborator
stevensJourney
left a comment
There was a problem hiding this comment.
Happy from my side :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the abstract
SyncConfigclass which is extended by the existingSqlSyncRulesand the newPrecompiledSyncConfigclass. This then refactors places whereSqlSyncRuleshave previously been used to now use the commonSyncConfigclass.The idea here is that can keep
SqlSyncRulesunchanged, and then have a separate but compatible class representing a compiled sync plan generated by the new compiler. In the future, it will also enable bucket storage implementations to store sync plans and return aPrecompiledSyncConfiginstance instead of recompiling toSqlSyncRuleswhen a sync plan is available.Since precompiled sync plans don't have errors, I've moved the
errorsfield to a separate interface (SyncConfigWithErrors).SyncConfigfollows the updated terminology we want to use to describe both sync rules and sync streams going forward.