Open
Conversation
Contributor
|
Tried the |
Contributor
|
The |
Contributor
|
Same for the |
miyamotoh
approved these changes
Sep 8, 2025
Contributor
miyamotoh
left a comment
miyamotoh
left a comment
There was a problem hiding this comment.
LGTM with some minor suggestions.
examples/Azure_example/Example.py
Outdated
| @@ -0,0 +1,125 @@ | |||
| # sample_azure_clients_functions.py | |||
Contributor
There was a problem hiding this comment.
This comment should really match the containing .py filename.
| @@ -0,0 +1,18 @@ | |||
| sudo dnf install cargo cmake python3.12 python3.12-devel ncurses gcc gcc-c++ libjpeg-devel gfortran --skip-broken --nobest | |||
Contributor
There was a problem hiding this comment.
I think you want -y to install these packages automatically.
examples/Azure_example/sub-test1.py
Outdated
| @@ -0,0 +1,130 @@ | |||
| # test_sample_azure_clients_functions.py | |||
Contributor
There was a problem hiding this comment.
Make this comment match the filename.
| @@ -0,0 +1,18 @@ | |||
| sudo dnf install cargo cmake python3.12 python3.12-devel ncurses gcc gcc-c++ libjpeg-devel gfortran --skip-broken --nobest | |||
Contributor
There was a problem hiding this comment.
Consider adding -y to the command.
| @@ -0,0 +1,18 @@ | |||
| sudo dnf install cargo cmake python3.12 python3.12-devel ncurses gcc gcc-c++ libjpeg-devel gfortran --skip-broken --nobest | |||
Contributor
There was a problem hiding this comment.
Consider adding -y to the command.
Contributor
|
Ran the new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added examples for the Azure family packages , bcrypt package and black package.