-
Notifications
You must be signed in to change notification settings - Fork 36
Armv8.1-M: Add MVE Keccak-f1600 x4 implementation #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mkannwischer
wants to merge
6
commits into
main
Choose a base branch
from
mve-keccak-x4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkannwischer
commented
Jan 27, 2026
- Resolves Port: Armv8.1-M: Add MVE Keccak-f1600 x4 implementation #908
- Ported from Armv8.1-M: Add MVE Keccak-f1600 x4 implementation mlkem-native#1518
…ends only Unit tests for Backends not support arthmetic do not use various i32 helper functions resulting in unused function warnings. This commit fixes that by introducing appropriate guards. chknorm is an outlier here - it only uses generate_i32_array_ranged, but not the other functions. We, hence, need 3 different guards that include/exclude chknorm accordingly. - Port of pq-code-package/mlkem-native@33c4af5 Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
Test both optimized and non-optimized builds on M55-AN547. - Port of pq-code-package/mlkem-native@4215daf Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
The avr and arm-embedded cross-shells were deviating in terms of their name from the other cross shells. This commit renames them to ci-cross-avr and ci-cross-arm-embedded. ci-cross-avr is not yet available for mldsa-native. - Port of pq-code-package/mlkem-native@5248a2b Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
Numerous nix shells were prefixed with ci- and ci_. I don't think that prefix serves any meaningful purpose other than signaling that at some point we set them up for CI. This commit removes the prefix from all nix shells and adjusts CI accordingly. - Port of pq-code-package/mlkem-native@d9fb732 Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
Contributor
CBMC Results (ML-DSA-65)Full Results (174 proofs)
|
Contributor
CBMC Results (ML-DSA-44)Full Results (174 proofs)
|
Contributor
CBMC Results (ML-DSA-87)
Full Results (174 proofs)
|
Add 4-way parallel Keccak-f1600 permutation for Armv8.1-M with MVE, using bit-interleaved state representation. - Add keccak_f1600_x4_mve.S: MVE assembly for 4-way Keccak - Add keccak_f1600_x4_mve.c: C wrapper with temporary bit-interleaving (to be eliminated once we have XORBytes and ExtractBytes implementations handling the bitinterleaving) - Adjust simpasm to support Armv8.1-M Thumb assembly simplification - Resolves #908 - Port of pq-code-package/mlkem-native@065c735 Co-Authored-By: Brendan Moran <brendan.moran@arm.com> Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
The Armv8.1-M + MVE backend is still in active development and has not undergone the same level of audit as the rest of the code. This commit extends the documentation to make this clear. The commit also disables the Armv8.1-M + MVE backend by default, and instead explicitly enables it in the an547 baremetal Makefile. - Port of pq-code-package/mlkem-native@9d2f1c2 Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
6474874 to
d3bec89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.