Skip to content

add optional includes to plugin options#28

Open
OlegLustenko wants to merge 3 commits intopradel:mainfrom
OlegLustenko:feature/optionalIncludes
Open

add optional includes to plugin options#28
OlegLustenko wants to merge 3 commits intopradel:mainfrom
OlegLustenko:feature/optionalIncludes

Conversation

@OlegLustenko
Copy link

@OlegLustenko OlegLustenko commented Jul 11, 2022

Hi, I see your other plugin such as craco-esbuild

And craco-esbuild has 1 more settings such as optionalIncludes.
I've extended this plugin so it's also contains this property

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2022

⚠️ No Changeset found

Latest commit: 9a943d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Owner

@pradel pradel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the change!
Could you please update the documentation file similar to reflect the option?

@OlegLustenko
Copy link
Author

@pradel, thanks for review and good point, updated!

@pradel
Copy link
Owner

pradel commented Jul 28, 2022

@OlegLustenko could you just add a changeset to the pr? I will be able to release it directly that way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants