Skip to content

Conversation

@etorreborre
Copy link
Contributor

@etorreborre etorreborre commented Jan 26, 2026

The PR makes sure that we can connect to an upstream node if:

  • It is not yet started when we start.
  • It is restarted while we are connected.

In order to do this:

  • The reading/writing stages in the Muxer are supervised.
  • The Muxer itself is supervised by the Connection which closes the loop since the Connection is supervised by the Manager.
  • FetchBlock errors are not considered as fatal anymore since they can happen on disconnection.
  • Similarly a rollback can fail on reconnection if the corresponding block was not yet applied to the ledger
    -> This seems to be a fundamental issue with how we maintain consistency between the ledger and the chain store. This will be addressed in another PR.

In addition:

  • Two tests were added to support the 2 disconnection scenarii presented earlier.
  • The tests were refactored since the setup and the assertions contains more code now.
  • The Muxer has a role field that is used to annotate traces, which is useful when reading log messages.
  • The connection timeout that was hard-coded in the Manager is now part of its configuration.

@etorreborre etorreborre self-assigned this Jan 26, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 26, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@etorreborre
Copy link
Contributor Author

@CodeRabbit review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 26, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@etorreborre etorreborre force-pushed the etorreborre/fix/reconnection-to-upstream branch from 3f24d68 to c0eff15 Compare January 26, 2026 13:07
@etorreborre etorreborre force-pushed the etorreborre/feat/block-fetch-test branch 6 times, most recently from 1a1e2b3 to 34094d3 Compare January 27, 2026 16:58
@etorreborre etorreborre force-pushed the etorreborre/fix/reconnection-to-upstream branch 2 times, most recently from 4d4bc63 to 2825fc0 Compare January 27, 2026 17:16
@etorreborre etorreborre force-pushed the etorreborre/feat/block-fetch-test branch from 34094d3 to 9b3c90a Compare January 27, 2026 17:16
@etorreborre etorreborre force-pushed the etorreborre/fix/reconnection-to-upstream branch from 2825fc0 to 646be60 Compare January 27, 2026 17:21
@etorreborre etorreborre force-pushed the etorreborre/feat/block-fetch-test branch from 9b3c90a to b3e052a Compare January 27, 2026 17:24
@etorreborre etorreborre force-pushed the etorreborre/fix/reconnection-to-upstream branch from 646be60 to e78c040 Compare January 27, 2026 17:27
@etorreborre etorreborre marked this pull request as ready for review January 27, 2026 17:27
@etorreborre etorreborre force-pushed the etorreborre/fix/reconnection-to-upstream branch from e78c040 to 8a1c929 Compare January 27, 2026 17:32
@etorreborre etorreborre force-pushed the etorreborre/feat/block-fetch-test branch 2 times, most recently from f70c73a to 1be90ed Compare January 28, 2026 09:48
Signed-off-by: etorreborre <etorreborre@yahoo.com>
@etorreborre etorreborre requested a review from rkuhn January 28, 2026 10:03
…n the responder is started

Signed-off-by: etorreborre <etorreborre@yahoo.com>
@etorreborre etorreborre force-pushed the etorreborre/fix/reconnection-to-upstream branch from 8a1c929 to 3ed55cf Compare January 28, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants