-
Notifications
You must be signed in to change notification settings - Fork 18
fix: set the proper max buffer size for the blockfetch and txsubmission protocols #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdjusts buffer limits in two protocol modules: BlockFetch reduces Changes
Estimated Code Review Effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…on protocols Signed-off-by: etorreborre <etorreborre@yahoo.com>
530a7d4 to
fa55d4e
Compare
rkuhn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can set this limit, it is the one written in the network spec, but ultimately this limit depends on how many blocks are in the range that we request. The pessimistic assumption is that we get all the blocks from the server before we can start processing them, meaning that they must fit into the muxer buffer. It was my understanding that blocks are currently smaller than 100kB and will get bigger with Leios. We’ll have to update this limit once we settle on our block fetching strategy.
According to the network specification.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.