Skip to content

Conversation

@pragmatrix
Copy link
Owner

No description provided.

@pragmatrix pragmatrix requested a review from Copilot January 30, 2026 13:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables launching application instances from launcher presenters in the project view, extending the band-based instance management system to support multiple locations for presenting instances.

Changes:

  • Added UserIntent return values to event processing methods to propagate instance launch requests up the presenter hierarchy
  • Extended BandPresenter functionality to launcher presenters, allowing each launcher to manage its own band of instances
  • Introduced BandLocation enum to distinguish between top-level band and launcher-specific bands
  • Refactored event routing and focus path handling to support nested band navigation within project launchers

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
shapes/src/shape.rs Added architectural comment about color field duplication
shapes/src/glyph_run.rs Added builder method for setting text color
scene/src/objects.rs Added Clone derive to Visual with explanatory comment
scene/src/handle.rs Added conditional update method with performance comments
layout/src/layouter.rs Changed callback signature to pass parameters separately
geometry/src/lib.rs Added ToPixels trait for Point conversion
desktop/src/projects/project_presenter.rs Updated to return UserIntent and handle band navigation
desktop/src/projects/mod.rs Added Band variant to ProjectTarget enum
desktop/src/projects/launcher_presenter.rs Extended with band presentation and instance management
desktop/src/lib.rs Added box_to_rect layout helper function
desktop/src/focus_target.rs Suppressed unused warnings
desktop/src/focus_path.rs Moved PartialEq constraint to impl blocks
desktop/src/event_router.rs Updated Default bound with PartialEq
desktop/src/desktop_presenter.rs Refactored to support multiple band locations
desktop/src/desktop_interaction.rs Updated interaction handling for UserIntent propagation
desktop/src/desktop.rs Enhanced instance creation with band location support
desktop/src/band_presenter.rs Made originating_from optional with default panel size
Comments suppressed due to low confidence (1)

desktop/src/projects/launcher_presenter.rs:1

  • Corrected spelling of 'exist' to 'exists'.
use std::time::{Duration, Instant};

pragmatrix and others added 2 commits January 30, 2026 14:18
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pragmatrix pragmatrix merged commit 2b522b1 into master Jan 30, 2026
1 of 4 checks passed
@pragmatrix pragmatrix deleted the launcher-instance branch January 30, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants