Skip to content

Conversation

@pragmatrix
Copy link
Owner

The goal of this PR is to pass the parameters from the configuration to the instance's environment.

@pragmatrix pragmatrix requested a review from Copilot February 1, 2026 06:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces support for passing configuration parameters from launch profiles to instance environments. Parameters are now represented as a Map<String, Value> from serde_json, replacing the custom Parameters and Parameter types. The parameters flow from TOML configuration through launch profiles and user intents to the instance environment where applications can access them.

Changes:

  • Replaced custom parameter types with serde_json::Map<String, Value> for better type flexibility
  • Modified CreationMode::New to carry InstanceParameters
  • Added InstanceContext::parameters() method for accessing parameters during instance creation

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
desktop/src/projects/configuration/types.rs Removed custom Parameters and Parameter types; changed LaunchProfile.params to use Map<String, Value>
desktop/src/projects/configuration/toml_reader.rs Updated TOML parsing to convert values directly to serde_json::Value instead of strings
desktop/src/projects/launcher_presenter.rs Added parameters field to StartInstance user intent
desktop/src/desktop_interaction.rs Updated UserIntent::StartInstance to include InstanceParameters field
desktop/src/desktop.rs Modified instance spawning to pass parameters through CreationMode::New
applications/src/instance_environment.rs Added parameters field and with_parameters builder method
applications/src/instance_context.rs Changed CreationMode::New to carry parameters; added parameters() accessor method
desktop/src/instance_manager.rs Removed unused creation_mode field from RunningInstance
desktop/src/projects/mod.rs Simplified parameter initialization using Default::default()
Cargo.toml Updated serde_json version from 1.0.116 to 1.0.149

@pragmatrix pragmatrix merged commit ae9c055 into master Feb 1, 2026
0 of 4 checks passed
@pragmatrix pragmatrix deleted the instance-parameterization branch February 1, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants