Open
Conversation
joeyhodge
commented
Nov 20, 2025
| FOR /F "tokens=*" %%g IN ('git rev-parse HEAD') DO (SET UEVR_COMMIT_HASH=%%g) | ||
|
|
||
| FOR /F "tokens=*" %%t IN ('git describe --tags --abbrev^=0') DO (SET UEVR_TAG=%%t) | ||
| FOR /F "tokens=*" %%t IN ('git describe --tags --always --abbrev^=0') DO (SET UEVR_TAG=%%t) |
Author
There was a problem hiding this comment.
able to remove --always switch if not needed
joeyhodge
commented
Nov 20, 2025
| IF "%UEVR_TAG%"=="" (SET UEVR_TAG=no_tag) | ||
|
|
||
| FOR /F "tokens=*" %%c IN ('git describe --tags --long') DO ( | ||
| FOR /F "tokens=*" %%c IN ('git describe --tags --always --long') DO ( |
Author
There was a problem hiding this comment.
able to remove --always switch if not needed
joeyhodge
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update MakeCommitHash.bat to remove wmic and use 'always' flag for robustness, as your commit hash date/time stamp specifically has been failing to generate for a few months now. same patch was applied to REFramework in praydog/REFramework#1421
before change, while compiling backend, in log:
Generating commit hash...
'wmic' is not recognized as an internal or external command,
operable program or batch file.
Building Custom Rule D:/a/UEVR/UEVR/CMakeLists.txt
after change:
no errors