Skip to content

Conversation

@IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Dec 1, 2025

This PR adds a surrogate variant to the existing participant micro-dumux, called the micro-dumux-surrogate. The surrogate is created using the tool BayesValidRox. The surrogate is built using PCE (Polynomial Chaos Expansion). This participant is built to highlight the functionality of model adaptivity in the Micro Manager: precice/micro-manager#198

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@IshaanDesai IshaanDesai self-assigned this Dec 1, 2025
@IshaanDesai IshaanDesai marked this pull request as ready for review December 28, 2025 10:31
Copy link
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not yet tried to run it, but here are some first, easy-to-address comments.

@@ -0,0 +1 @@
- Added PCE-base surrogate for micro-dumux in two-scale heat conduction [#684](https://github.com/precice/tutorials/pull/684)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md file of the tutorial also needs to document this alternative and what kind of surrogate it is.

In other cases (e.g., perpendicular-flap), we had participants named -fake? Is this case doing something similar?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this directory, and how is it related to the micro-dumux-surrogate/?
What does mada stand for?
Why is there no run.sh and clean.sh, if this is a case directory?

@@ -0,0 +1,56 @@
"""
Micro simulation Surrogate, requrie previous computation of surrogate model
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Micro simulation Surrogate, requrie previous computation of surrogate model
Micro simulation Surrogate, requries previous computation of surrogate model

?

Comment on lines +4 to +7
python3 -m venv .venv
. .venv/bin/activate

pip install -r requirements.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #680 for some updates (or directly copy from other run.sh in the same tutorial).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants