-
-
Notifications
You must be signed in to change notification settings - Fork 129
Add micro-dumux-surrogate participant to two-scale heat conduction #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
MakisH
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not yet tried to run it, but here are some first, easy-to-address comments.
| @@ -0,0 +1 @@ | |||
| - Added PCE-base surrogate for micro-dumux in two-scale heat conduction [#684](https://github.com/precice/tutorials/pull/684) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README.md file of the tutorial also needs to document this alternative and what kind of surrogate it is.
In other cases (e.g., perpendicular-flap), we had participants named -fake? Is this case doing something similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this directory, and how is it related to the micro-dumux-surrogate/?
What does mada stand for?
Why is there no run.sh and clean.sh, if this is a case directory?
| @@ -0,0 +1,56 @@ | |||
| """ | |||
| Micro simulation Surrogate, requrie previous computation of surrogate model | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Micro simulation Surrogate, requrie previous computation of surrogate model | |
| Micro simulation Surrogate, requries previous computation of surrogate model |
?
| python3 -m venv .venv | ||
| . .venv/bin/activate | ||
|
|
||
| pip install -r requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #680 for some updates (or directly copy from other run.sh in the same tutorial).
This PR adds a surrogate variant to the existing participant micro-dumux, called the micro-dumux-surrogate. The surrogate is created using the tool BayesValidRox. The surrogate is built using PCE (Polynomial Chaos Expansion). This participant is built to highlight the functionality of model adaptivity in the Micro Manager: precice/micro-manager#198
Checklist:
changelog-entries/<PRnumber>.md.