Open
Conversation
Author
|
Please note that I did release my fork to RubyGems as stackbuilders-campfire_export so that it can be more broadly used and tested. I updated the documentation on our fork to describe the fixes that have been made, and how to install the updated gem from RubyGems. If you decide to merge the changes from my fork and make a new release, I'll gladly point back to your original repo and yank my own published gem. Thanks again for this gem, which helped us to export our 1.3 GB of data from Campfire. :) |
when the XML response doesn't include a proper date, the exception handling function causes an error.
improper rescue clause caused errors when no date returned in XML from campfire.
Fix error handling when Campfire API doesn't return a proper date
|
Thanks for this fix. This is working well on Ruby 2.2.3 with El Capitan! |
Author
|
@jqr you're welcome. Glad to hear it was helpful. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for this useful library.
I made several changes and fixes so that I could use this program to export a large Campfire history:
Note that after merging you should enable travis for this repo and change the README to point to your travis instance. Other than that there are no other changes that are specific to my configuration.
Please let me know if you feel ok making changes this large to the codebase and pushing a new gem. My only concern is that there isn't a ton of test support present, and my only testing of my changes is quickly visually inspecting that an export of > 1 GB looks pretty much ok.
If you're not comfortable merging this yet and pushing a new gem release, I can push this to another gem name temporarily, e.g.,
stackbuilders-campfire_export, and if there is some manually testing done by other users we can merge this into your main codebase, and push a new gem using your account when you feel comfortable that it has had enough testing. Let me know how you'd like to proceed, and thanks very much for your work on this gem which has been very useful to us @stackbuilders!