Differentiate different types of Drift failures#37
Open
tdcmeehan wants to merge 1 commit intoprestodb:masterfrom
Open
Differentiate different types of Drift failures#37tdcmeehan wants to merge 1 commit intoprestodb:masterfrom
tdcmeehan wants to merge 1 commit intoprestodb:masterfrom
Conversation
It's sometimes useful to log the reason for a failure. By separating out the specific failure reasons into different exceptions, clients can now inspect the underlying failure reason. This may be useful for logging, or for publication of custom metrics.
aweisberg
suggested changes
Oct 11, 2021
| cause = new TTransportException(e.getMessage()); | ||
| } | ||
|
|
||
| RetriesFailedException retriesFailedException = new RetriesFailedException( |
There was a problem hiding this comment.
You can delete the class for this now?
There was a problem hiding this comment.
RetriesFailedException has been renamed as DriftRetriesFailedException
| int overloadedRejects, | ||
| Set<? extends Address> attemptedAddresses) | ||
| { | ||
| super(format("Max retry time (%s) exceeded", maxRetryTime), invocationAttempts, retryTime, failedConnections, overloadedRejects, attemptedAddresses); |
There was a problem hiding this comment.
These exception classes are structurally identical so maybe they could be one? These could be reason codes. Don't feel very strongly about it though.
Is there some other idiom you are following?
ajaygeorge
approved these changes
Oct 11, 2021
ajaygeorge
left a comment
ajaygeorge
left a comment
There was a problem hiding this comment.
LGTM overall. % comments from Ariel on using codes .
wanglinsong
force-pushed
the
master
branch
5 times, most recently
from
f6789f1 to
ffd0e7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's sometimes useful to log the reason for a failure. By separating out the specific
failure reasons into different exceptions, clients can now inspect the underlying failure
reason. This may be useful for logging, or for publication of custom metrics.