Open
Conversation
kaikalur
force-pushed
the
cpp_unparse
branch
2 times, most recently
from
aed76e1 to
7eff287
Compare
rongrong
reviewed
Feb 17, 2021
rongrong
left a comment
rongrong
left a comment
There was a problem hiding this comment.
Is there any tests running the logic already?
parser/cpp/AstNode.h
Outdated
| AstNode* GetChild(int i) { return static_cast<AstNode*>(jjtGetChild(i)); } | ||
| JJString toString(const JJString& prefix) const { | ||
|
|
||
| int Kind() const { return id; } |
There was a problem hiding this comment.
Should function name start with lower case?
Author
There was a problem hiding this comment.
Yeah - it's one of the weird things that happened when we did C++ first and then java. Will fix it.
Author
There was a problem hiding this comment.
Actually, in C++ the style is upper case starting letter. So not changing it here.
parser/grammar/presto-extensions.txt
Outdated
| "NUMERIC_HISTOGRAM" | ||
| | "HISTOGRAM" | ||
| | "APPROEX_PERCENTILE" | ||
| | "APPROX_PERCENTILE" |
There was a problem hiding this comment.
This fix should probably be a separate commit/PR?
kaikalur
force-pushed
the
cpp_unparse
branch
3 times, most recently
from
186bd59 to
71765a1
Compare
kaikalur
force-pushed
the
cpp_unparse
branch
3 times, most recently
from
1222619 to
5aad9e0
Compare
Author
|
Build now! Also, looks like we lost Leiqing's changes? Somehow the pom.xml in main doesn't have the sonatype stuff. So looks like some other merges clobbered. You will see them here now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring C++ somewhat on-par with Java.